Rework and enable Wasm.Build.Tests.Blazor.AssetCachingTests by oroztocil · Pull Request #123388 · dotnet/runtime

oroztocil · 2026-01-20T17:18:54Z

AssetCachingTests check that only the expected requests for Wasm assets are actually sent by the client to the server, based on whether asset fingerprinting is enabled or not. Fingerprinted assets should be always retrieved from the browser cache after the initial load.

Previously, the test relied on reading server logs from the stdout of the test server application. This was likely the cause of the test's flakiness.

The PR replaces the mechanism with an API endpoint exposed by the the server that is used by the test code to retrieve the captured request logs. The test is re-enabled and added to BuildWasmAppsJobsList.txt.

…achingTest

Copilot

Pull request overview

This PR refactors the Wasm.Build.Tests.Blazor.AssetCachingTests to improve test reliability by replacing stdout-based log parsing with an HTTP API endpoint. The test server now exposes /request-logs endpoints to retrieve and clear captured request logs, eliminating the previous source of flakiness.

Changes:

Added request logging middleware and API endpoints to the BlazorWebWasm test server
Created a client library (BlazorWebWasmLogClient) to interact with the logging API from tests
Updated the test to use the new API-based approach instead of parsing server stdout
Updated target framework from net10.0 to net11.0 in test assets
Optimized Counter.razor to log only on first render
Re-enabled the test by removing the ActiveIssue attribute and adding it back to BuildWasmAppsJobsList.txt

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
BlazorWebWasm/Program.cs	Added middleware to capture HTTP request logs and API endpoints to retrieve/clear logs
BlazorWebWasmRequestLog.cs (testasset)	New record type for capturing request details in the test server
BlazorWebWasm.csproj	Updated target framework from net10.0 to net11.0
BlazorWebWasm.Client.csproj	Updated target framework from net10.0 to net11.0
Counter.razor	Modified to log only on first render to reduce noise
ServerRequestLog.cs	New record type (appears unused)
BlazorWebWasmRequestLog.cs (test)	New record type matching the testasset structure for deserialization
BlazorWebWasmLogClient.cs	New HTTP client for interacting with the test server's logging API
AssetCachingTests.cs	Refactored to use the new API-based logging approach, removed ActiveIssue attribute
BuildWasmAppsJobsList.txt	Re-enabled AssetCachingTests in the test job list

src/mono/wasm/testassets/BlazorWebWasm/BlazorWebWasm/Program.cs

src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWebWasmLogClient.cs

src/mono/wasm/testassets/BlazorWebWasm/BlazorWebWasm/Program.cs

src/mono/wasm/Wasm.Build.Tests/Common/ServerRequestLog.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-01-20T17:36:34Z

@oroztocil I've opened a new pull request, #123390, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-20T17:37:41Z

@oroztocil I've opened a new pull request, #123392, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-01-20T17:43:47Z

@oroztocil I've opened a new pull request, #123393, to work on those changes. Once the pull request is ready, I'll request review from you.

maraf

Looks great! 👍

src/mono/wasm/testassets/BlazorWebWasm/BlazorWebWasm/Program.cs

dotnet-policy-service · 2026-01-21T11:23:05Z

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWebWasmLogClient.cs

javiercn

Looks good.

oroztocil · 2026-01-21T11:59:45Z

@copilot Implement changes proposed by @javiercn in comments

Copilot · 2026-01-21T11:59:58Z

@oroztocil I've opened a new pull request, #123430, to work on those changes. Once the pull request is ready, I'll request review from you.

src/mono/wasm/testassets/BlazorWebWasm/BlazorWebWasm/BlazorWebWasm.csproj

src/mono/wasm/testassets/BlazorWebWasm/BlazorWebWasm.Client/BlazorWebWasm.Client.csproj

src/mono/wasm/Wasm.Build.Tests/Blazor/AssetCachingTests.cs

oroztocil · 2026-02-02T13:10:16Z

/backport to release/10.0

github-actions · 2026-02-02T13:10:26Z

Started backporting to release/10.0 (link to workflow run)

Add request log endpoint to BlazorWebWasm, rework and reenable AssetC…

2887352

…achingTest

oroztocil requested a review from maraf as a code owner January 20, 2026 17:18

Copilot AI review requested due to automatic review settings January 20, 2026 17:18

oroztocil requested a review from ilonatommy as a code owner January 20, 2026 17:18

oroztocil removed the request for review from maraf January 20, 2026 17:19

github-actions bot added the area-Build-mono label Jan 20, 2026

dotnet-policy-service bot assigned oroztocil Jan 20, 2026

oroztocil requested a review from maraf January 20, 2026 17:19

oroztocil added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Jan 20, 2026

Copilot started reviewing on behalf of oroztocil January 20, 2026 17:19 View session

oroztocil removed the area-Build-mono label Jan 20, 2026

Copilot AI reviewed Jan 20, 2026

View reviewed changes

Update BlazorWebWasmLogClient.cs

7d25638

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This was referenced Jan 20, 2026

Add thread-safe locking to request logging in BlazorWebWasm #123390

Merged

Implement IDisposable in BlazorWebWasmLogClient #123392

Merged

Update Program.cs

2d89d8b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Jan 20, 2026

Delete unused ServerRequestLog.cs file #123393

Merged

Copilot AI added 3 commits January 20, 2026 18:50

Delete unused ServerRequestLog.cs file (#123393)

8445e6e

Implement IDisposable in BlazorWebWasmLogClient (#123392)

d8da55b

Add thread-safe locking to request logging in BlazorWebWasm (#123390)

05ff18c

maraf approved these changes Jan 21, 2026

View reviewed changes

maraf added test-enhancement Improvements of test source code area-Infrastructure-mono labels Jan 21, 2026

maraf added this to the 11.0.0 milestone Jan 21, 2026

javiercn reviewed Jan 21, 2026

View reviewed changes

src/mono/wasm/testassets/BlazorWebWasm/BlazorWebWasm/Program.cs Outdated Show resolved Hide resolved

javiercn reviewed Jan 21, 2026

View reviewed changes

src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWebWasmLogClient.cs Outdated Show resolved Hide resolved

javiercn approved these changes Jan 21, 2026

View reviewed changes

Copilot AI mentioned this pull request Jan 21, 2026

Rework and enable Wasm.Build.Tests.Blazor.AssetCachingTests #123430

Merged

Rework and enable Wasm.Build.Tests.Blazor.AssetCachingTests (#123430)

4724c7c

oroztocil enabled auto-merge (squash) January 21, 2026 13:54

ilonatommy reviewed Jan 21, 2026

View reviewed changes

src/mono/wasm/testassets/BlazorWebWasm/BlazorWebWasm/BlazorWebWasm.csproj Show resolved Hide resolved

src/mono/wasm/testassets/BlazorWebWasm/BlazorWebWasm.Client/BlazorWebWasm.Client.csproj Show resolved Hide resolved

ilonatommy reviewed Jan 21, 2026

View reviewed changes

src/mono/wasm/Wasm.Build.Tests/Blazor/AssetCachingTests.cs Show resolved Hide resolved

oroztocil merged commit ebae784 into main Jan 21, 2026
27 checks passed

This was referenced Jan 21, 2026

[prvysoky/demo] Source code updates from dotnet/runtime dotnet/dotnet#4337

Closed

[prvysoky/demo] Source code updates from dotnet/runtime dotnet/dotnet#4340

Closed

[main] Source code updates from dotnet/runtime dotnet/dotnet#4351

Merged

jkotas deleted the oroztocil/asset-caching-test-fix branch January 24, 2026 03:44

Copilot AI mentioned this pull request Feb 2, 2026

[WIP] Create draft PR for backporting test changes #123880

Closed

4 tasks

github-actions bot mentioned this pull request Feb 2, 2026

[release/10.0] Rework and enable Wasm.Build.Tests.Blazor.AssetCachingTests #123883

Open

4 tasks

Conversation

oroztocil commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 20, 2026

Uh oh!

Copilot AI commented Jan 20, 2026

Uh oh!

Copilot AI commented Jan 20, 2026

Uh oh!

maraf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dotnet-policy-service bot commented Jan 21, 2026

Uh oh!

Uh oh!

javiercn left a comment

Choose a reason for hiding this comment

Uh oh!

oroztocil commented Jan 21, 2026

Uh oh!

Copilot AI commented Jan 21, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oroztocil commented Feb 2, 2026

Uh oh!

github-actions bot commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

oroztocil commented Jan 20, 2026 •

edited

Loading